This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
[2.0.x] epe-37 fixed test-contracts build #9101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimjh2005
changed the title
larryk85
suggested changes
May 19, 2020
| #include <eosiolib/print.hpp> | ||
| #include <eosiolib/privileged.h> | ||
| #include <eosiolib/transaction.hpp> | ||
| #include <eosiolib/contracts/eosio/action.hpp> |
There was a problem hiding this comment.
The way the default includes work is that you can use #include <eosio/action.hpp>. You don't need the eosiolib/[contracts|core|capi] part. Also, we shouldn't be including the capi headers, use the c++ equivalent headers. These will include the capi headers for you.
|
This seems like a lot for |
|
If it doesn't have to be back ported to release/2.0.x. I will close the PR. |
|
I will close this PR as it is too late to merge it to 2.0.x. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the removal of those deprecated headers in eosio.cdt v1.7.x, it is not possible to build EOSIO with -DEOSIO_COMPILE_TEST_CONTRACTS=true with an installed version of eosio.cdt of 1.7.x or later.
https://blockone.atlassian.net/browse/EPE-37
Change Description
#1. Changed include path from eosiolib/* to eosiolib/capi/, eosiolib/core/, eosiolib/contracts/*.
#2. Added namespace if call to a function is ambiguous
#3. Handled function arguments changes.
Consensus Changes
API Changes
Documentation Additions